Fix last used and favourite tracking issues - Githubissues

nebari-dev / jupyterlab-launchpad

BSD 3-Clause "New" or "Revised" License

13 stars 2 forks source link

Fix last used and favourite tracking issues #39

Closed krassowski closed 5 months ago

krassowski commented 5 months ago

Reference Issues or PRs

fixes #29
- fix last used not getting saved when kernel was created from dialog
- fix favourites not being updated when changed in another launcher/dialog
- fix last used not being updated for auto-started kernels

What does this implement/fix?

Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

github-actions[bot] commented 5 months ago

:point_left: Launch a Binder on branch nebari-dev/jupyterlab-new-launcher/track-kernels-created-externally