Improve UI for Create New modal

nebari-dev / jupyterlab-launchpad

BSD 3-Clause "New" or "Revised" License

13 stars 2 forks source link

Improve UI for Create New modal #40

Closed kcpevey closed 1 month ago

kcpevey commented 5 months ago

Context

When you click "notebook" via "create empty", the modal has a lot of space for "start a new kernel" and very little space for "connect to a running kernel". The "Connect to a running kernel" table has only one line visible.

https://github.com/nebari-dev/jupyterlab-new-launcher/assets/15659110/1bd08259-2395-434a-ad70-00eb6ba56e76

Value and/or benefit

More balanced UI and improved UX when selecting a "running kernel"

Anything else?

Sidenote - I dont know what "connect to a running kernel" means. Instead of launching new, do I want to just load an already running notebook??

krassowski commented 5 months ago

I dont know what "connect to a running kernel" means. Instead of launching new, do I want to just load an already running notebook?

Yes, this is useful if you want to draft some code in a console side-by-side with notebook:

one user flow is to have notebook on the left for noting down the results and console on the right for prototyping code; once a user is happy with a result they drag the cell out of console to the notebook - this way all previous attempts are still tracked, but do not clobber the notebook.
another user story is to have one notebook for live data visualisation, and another for the actual model code, open side-by-side connected to the same kernel; this allows you to monitor the results of your models without scrolling back and forth.

krassowski commented 5 months ago

While the top table takes up more space, I cannot quite reproduce the bottom table getting down to a single row, neither in Chrome nor in Firefox:

Chrome	Firefox

I suspect this state can arise due to delayed rendering with react.

kcpevey commented 5 months ago

I suspect this state can arise due to delayed rendering with react.

When would this happen? I'm testing on Chrome within Nebari - is that having an effect?

kcpevey commented 2 months ago

Now I'm in a state where the bottom table is reduced down to a tiny sliver. The top table has a scroll bar, but its still taking up too much room.

krassowski commented 1 month ago

Reproduced in Chrome. I had to create at least 40 environments and resize browser window down.