Add commands to open URL in new window, and to deploy App in new window

nenb commented 1 month ago

This PR adds a new command: deploy-app.

deploy-app

Opens the URL for the deploy-app page in a new browser tab. Also passes a query parameter for filepath that is generated from the current workspace in JLab.

Reference Issues or PRs

https://github.com/nebari-dev/jhub-apps/issues/472

What does this implement/fix?

Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation

Access-centered content checklist

Text styling

[ ] The content is written with plain language (where relevant).
[ ] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[ ] All links describe where they link to (for example, check the Nebari website).
[ ] This content adheres to the Nebari style guides.

Non-text content

[ ] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[ ] If there are emojis, there are not more than three in a row.
[ ] Don't use flashing GIFs or videos.
[ ] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

github-actions[bot] commented 1 month ago

:point_left: Launch a Binder on branch nenb/jupyterlab-nebari-mode/deploy-app-ext

nenb commented 1 month ago

@krassowski Quick follow-up:

Great start! Do you plan to add the button to the toolbar and context menu in this PR or subsequent one?

I was under the impression that these would be configured in the settings in jhub-apps/nebari, rather than adding them here.

What's the usual practice? That an extension includes these settings by default, and then a user (e.g. nebari deployment) can disable them if they require?

krassowski commented 1 month ago

I was under the impression that these would be configured in the settings in jhub-apps/nebari, rather than adding them here.

I think its better to include them here in a single plugin rather than in nebari. This is because it will be much easier to test it if it is completely independent of nebari. jhub-apps currently has no JupyterLab extensions. We can later extract that plugin to make it live closer to jhub-apps.

krassowski commented 1 month ago

That an extension includes these settings by default, and then a user (e.g. nebari deployment) can disable them if they require?

Yes, it is much easier to:

do proper visual testing here and ship a standalone plugin
flip "enabled" flag one per-plugin basis in nebari

than if we were to split the logic between the two.

kcpevey commented 1 month ago

Just wanted to mention that we need to keep in mind that jhub-apps is an optional feature of Nebari and therefore the changes we introduce here should also be safe for when jhub-apps is not present. (Maybe this is already true, I dont know about the technical details here 😀)

nenb commented 1 month ago

Some screenshots of what it is currently looking like:

Context Menu