Update codeserver version to latest

viniciusdc commented 5 months ago

Update codeserver version from v4.5.1 to v4.23.1

Reference Issues or PRs

close #136

What does this implement/fix?

Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation

Access-centered content checklist

Text styling

[ ] The content is written with plain language (where relevant).
[ ] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[ ] All links describe where they link to (for example, check the Nebari website).
[ ] This content adheres to the Nebari style guides.

Non-text content

[ ] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[ ] If there are emojis, there are not more than three in a row.
[ ] Don't use flashing GIFs or videos.
[ ] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

marcelovilla commented 5 months ago

Thanks @viniciusdc!

krassowski commented 5 months ago

Worth testing this one solidly as I see some upstream reports that vscode-binder that we use:

https://github.com/nebari-dev/nebari-docker-images/blob/25697f163e296a7f03a513d0140b2b31ac109029/jupyterlab/environment.yaml#L61

does not work with code-server 4.10.1 and newer (https://github.com/betatim/vscode-binder/issues/38). Or do we use it only to get the vscode icon?

marcelovilla commented 5 months ago

@krassowski thanks for the heads up. Code server seems to be working fine but I'm not sure what we use vscode-binder for.

@viniciusdc do you know?

dharhas commented 5 months ago

We should probably be shifting to the code-server icon instead of the microsoft vscode icon if that is all it is used for. If we don't know what it is used for then we should remove it and find out that way.

marcelovilla commented 5 months ago

@dharhas I've added nebari-dev/nebari/#2417 to track this. I can transfer it to this repo if it makes more sense.

nebari-dev / nebari-docker-images