nebari-dev / nebari-docker-images

📦 Ready to use Docker images maintained by the Nebari team
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Pin `kubernetes_asyncio` to `29.0.0` #162

Closed aktech closed 3 months ago

aktech commented 3 months ago

Reference Issues or PRs

A recent release in kubernetes_asyncio has broken JupyterHub and jhub-apps.

Fixes #163

https://github.com/nebari-dev/nebari-docker-images/pull/161 needs to get in first to make the CI work again.

│   File "/opt/conda/lib/python3.9/site-packages/kubernetes_asyncio/config/kube_config.py", line 38, in <module>                                                                                                                                                               │
│     KUBE_CONFIG_DEFAULT_LOCATION = os.environ.get('KUBECONFIG', (pathlib.Path.home() / '.kube/config').as_posix())                                                                                                                                                           │
│   File "/opt/conda/lib/python3.9/pathlib.py", line 1143, in home                                                                                                                                                                                                             │
│     return cls(cls()._flavour.gethomedir(None))                                                                                                                                                                                                                              │
│   File "/opt/conda/lib/python3.9/pathlib.py", line 390, in gethomedir                                                                                                                                                                                                        │
│     return pwd.getpwuid(os.getuid()).pw_dir                                                                                                                                                                                                                                  │
│ KeyError: 'getpwuid(): uid not found: 1000'                                         

It was released on Jun 9, 2024 Pull request in upstream, that potentially caused it: https://github.com/tomplus/kubernetes_asyncio/pull/307

I have verified the error is gone in the previous version.

What does this implement/fix?

Put a x in the boxes that apply

Testing

Documentation

Access-centered content checklist

Text styling

Non-text content

Any other comments?

krassowski commented 3 months ago

Do we need to report the kubernetes_asyncio issue somewhere upstream so that it is fixed once we do need to migrate?

aktech commented 3 months ago

Do we need to report the kubernetes_asyncio issue somewhere upstream so that it is fixed once we do need to migrate?

I am still looking to see why it happened (with that innocent looking change) but didn't had the chance to create a minimal example (on why that small change affects us) to create an issue on upstream, I'll put up something sometime this week.

marcelovilla commented 3 months ago

@aktech do we need to get this in for the next Nebari release?

aktech commented 3 months ago

@marcelovilla Yes, absolutely, otherwise nebari jhub-apps is broken.