nebari-dev / nebari-docs

πŸ“– Documentation for Nebari
https://www.nebari.dev
BSD 3-Clause "New" or "Revised" License
14 stars 29 forks source link

Install Docs Update #473

Closed kenafoster closed 2 months ago

kenafoster commented 3 months ago

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

This PR intends to update the quick start and installation guides with the following clarifications:

Testing

Documentation

Access-centered content checklist

Text styling

Non-text content

Any other comments?

netlify[bot] commented 3 months ago

Deploy Preview for nebari-docs ready!

Name Link
Latest commit c15a812ee1aae8fc2bb8923ad4b094c09e9ab8aa
Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/66916676abb4c70008e2af55
Deploy Preview https://deploy-preview-473--nebari-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kenafoster commented 2 months ago

Hi @kenafoster this looks awesome, thanks for going over and submitting these πŸš€ I've made some suggestions here and there, let me know your thoughts.

Thank you! I've addressed most of them. One of the comments I need to give more thought (and will send one more commit), and I'm not sure about the nebari0 conda env you mentioned.

viniciusdc commented 2 months ago

Hi @kenafoster this looks awesome. Thanks for going over and submitting these πŸš€ I've made some suggestions here and there; let me know your thoughts.

Thank you! I've addressed most of them. One of the comments I need to give more thought to (and will send one more commit), and I'm not sure about the nebari0 conda env you mentioned.

Excellent, thanks, @kenafoster. I will have another look today. Do not worry too much about that; it only showcases an example of utilization.

kenafoster commented 2 months ago

@viniciusdc thanks, ready for re-review. Do you want to 'resolve conversation' on the comment chains where you're satisfied that I addressed your feedback? (Unless it is 100% good to merge now, in which case doesn't matter). Getting hard to track which to-dos are still open