Make sure that overriding instance type (nodeSelector), image, etc. works for users

nebari-dev / nebari-workflow-controller

A WIP kubernetes admission controller to control what workflows can be deployed by which users

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Make sure that overriding instance type (nodeSelector), image, etc. works for users #12

Closed Adam-D-Lewis closed 1 year ago

Adam-D-Lewis commented 1 year ago

Context

Value and/or benefit

Anything else?

No response

Adam-D-Lewis commented 1 year ago

nodeSelector is not preserved right now b/c it needs to go from the spec portion on the jupyterlab user pod to the container portion on Argo Workflows and I don't have a way to do that yet.

Adam-D-Lewis commented 1 year ago

nodeSelector should be under container. On the jupyterpod, you have to get it from spec though

  # argo workflow container
      - container:
          args:
          - uname -a
          command:
          - sh
          - -c
          image: alpine:latest
        inputs:
          parameters:
          - name: arch
        name: print-arch
        nodeSelector:
          beta.kubernetes.io/arch: '{{inputs.parameters.arch}}'

Adam-D-Lewis commented 1 year ago

I think this is resolved. I'll re open if needed.