nebari-dev / nebari-workflow-controller

A WIP kubernetes admission controller to control what workflows can be deployed by which users
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Enable NWC to mutate workflows created by service accounts #16

Closed iameskild closed 1 year ago

iameskild commented 1 year ago

Reference Issues or PRs

This PR is a related to the work being done to integrate Jupyter-Scheduler (#1832).

What does this implement/fix?

Put a x in the boxes that apply

Testing

Documentation

Access-centered content checklist

Text styling

Non-text content

Any other comments?

Adam-D-Lewis commented 1 year ago

Have you run the tests? Could we add a test for the new functionality?

iameskild commented 1 year ago

@costrouc @Adam-D-Lewis I added new tests that cover the special case where the Workflow was created via a service-account.

costrouc commented 1 year ago

Since @Adam-D-Lewis is on PTO and we are trying to get a release out for nebari. I am comfortable with merging. @iameskild feel free to merge when it works best.