search

nebari-dev / nebari-workflow-controller

A WIP kubernetes admission controller to control what workflows can be deployed by which users
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

`jupyterflow-override: true` won't work for CronWorkflows bc it's unlikely the user will have a jupyter pod around at the time the workflow starts #9

Closed Adam-D-Lewis closed 1 year ago

Adam-D-Lewis commented 1 year ago

Context

jupyterflow-override: true won't work for CronWorkflows bc it's unlikely the user will have a Cron Workflow around at the time the workflow starts

Adam-D-Lewis commented 1 year ago

I haven't tested CronWorkflows anyways. I should

Adam-D-Lewis commented 1 year ago

For CronWorkflows, we should get the pod image at the time the cron workflow is created.

Adam-D-Lewis commented 1 year ago

This is resolved. The CronWorkflows get the pod image at the time the cron workflow is created.