Open nkaretnikov opened 1 year ago
Yellow is the most problematic, but I'd prefer to just have --color=no
. Because you never know what terminal config someone uses.
Thanks for raising this with us @nkaretnikov! This is definitely something that will need to be sorted out.
seems like in the code there are various places where either rich.print
or console
is used.
Id suggest
rich.print
replace them with a corresponding console.print
--color=no
well just set all console.no_color = True
And then as a followup activity, we have to take out the direct color references eg [green][/green]
and replace them with style themes/semantic tags eg [uri][/uri]
as mentioned in #1478 . As in well leave those embedded stylings as is for now
@nkaretnikov @iameskild what do you guys think?
Edit:
rich.console
to the typer.Typer
constructor. Uncertain whether access to the typer console instance is accessible either. typer/rich_utils.py
does is the way to do it (STYLE_OPTION_ENVVAR
) but it does seem that _get_rich_console
seems to be instantiating a new console Theme all the time when the typer command gets rendered out.
Feature description
This is unreadable in a terminal with white background:
Provide an option to disable colors.
Some popular terminal configurations to test: ubuntu terminal, dark bg, white bg, solarized.
Value and/or benefit
See above.
Anything else?
6d01b048dd01e884d3a9f1d60ddebd4dbe96432e