nebari-dev / nebari

🪴 Nebari - your open source data science platform
https://nebari.dev
BSD 3-Clause "New" or "Revised" License
279 stars 92 forks source link

[ENH] - Make code server a login shell to act the same as jupyterlab #2612

Open Adam-D-Lewis opened 3 months ago

Adam-D-Lewis commented 3 months ago

Feature description

Currently, vs code terminal will not source .bash_profile if it exists, but jupyterlab does. The behavior can be standardized in Nebari by adding

{
    "terminal.integrated.defaultProfile.linux": "bash",
    "terminal.integrated.profiles.linux": {
    "bash": {
        "path": "bash",
        "args": ["-l"]
    }
    }
}

to the ~/.local/share/code-server/Machine/settings.json file on a Nebari deployment. Perhaps we could add this file, but still make it editable by the users.

Value and/or benefit

Make a consistent experience between Code server and jupyterlab.

Anything else?

No response

kcpevey commented 16 hours ago

I back this 1000%. Its confusing to users if you don't realize this.