search

nebari-dev / nebari

🪴 Nebari - your open source data science platform
https://nebari.dev
BSD 3-Clause "New" or "Revised" License
279 stars 89 forks source link

Put a "Redeploy may be needed" note on the next upgrade for Azure deployments #2640

Closed Adam-D-Lewis closed 3 weeks ago

Adam-D-Lewis commented 1 month ago

Context

I was testing out an upgrade (2024.7.1 -> develop) on Azure and the node groups get deleted and recreated b/c of the Rook Ceph PR, but there is a lag between when terraform thinks the node groups are destroyed and when AKS reports them as being destroyed so terraform tries to create a new "user" node group and terraform throws an error that a "user" node group already exists. Redeploying after the failure gives enough time for AKS to delete the old "user" node group and things work fine after that. I'm not sure if this is always an issue or just intermittently.

I'm not sure how to fix this b/c the error is on the terraform Azure provider side. Maybe we should include a note that this might be possible when users run nebari upgrade.

Adam-D-Lewis commented 1 month ago

Try to update Azure provider version

Adam-D-Lewis commented 3 weeks ago

Fixed by https://github.com/nebari-dev/nebari/pull/2726