nebari-dev / nebari

🪴 Nebari - your open source data science platform
https://nebari.dev
BSD 3-Clause "New" or "Revised" License
282 stars 93 forks source link

[ENH] Move Vault secrets and provider auth to custom action #2756

Closed viniciusdc closed 1 week ago

viniciusdc commented 1 month ago

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

Testing

How to test this PR?

Any other comments?

marcelovilla commented 1 month ago

@viniciusdc is this ready for review? Is there an associated issue?

marcelovilla commented 2 weeks ago

@viniciusdc with Vault failing relatively frequently, I'm wondering if we should consider just using GitHub secrets instead. Any thoughts?

C.C. @Adam-D-Lewis @dcmcand

dcmcand commented 2 weeks ago

I would be in favor of moving away from vault

marcelovilla commented 2 weeks ago

I opened https://github.com/nebari-dev/nebari/issues/2835

marcelovilla commented 1 week ago

We're going to address https://github.com/nebari-dev/nebari/issues/2835 so we won't be merging this PR