nebari-dev / nebari

🪴 Nebari - your open source data science platform
https://nebari.dev
BSD 3-Clause "New" or "Revised" License
282 stars 93 forks source link

Remove old develop branch references after default branch renaming #2769

Closed marcelovilla closed 1 month ago

marcelovilla commented 1 month ago

Reference Issues or PRs

Closes #2770

What does this implement/fix?

Put a x in the boxes that apply

Testing

How to test this PR?

You can manually trigger any of the cloud deployment workflows (i.e., AWS, Azure and Google Cloud) and specify main as the Nebari branch in the first text box (not from the dropdown menu in the first item).

Any other comments?

Adam-D-Lewis commented 1 month ago

They appear to be passing now. Is this PR still needed?

image

viniciusdc commented 1 month ago

I think the PR contents are still needed for legacy code removal, but the naming needs to be changed as well as the issue affiliation

marcelovilla commented 1 month ago

@Adam-D-Lewis huh, I thought this was the issue but you're right, they are passing now and pointing to the correct branch. As @viniciusdc mentioned, this PR is still relevant in the sense that it gets rid of old references to develop. I updated the issue title and opened and linked a new issue.