search

nebbian / RoboxSlicerExtension

Allows the use of different slicers when using the CEL Robox printer.
GNU General Public License v3.0
3 stars 2 forks source link

project structure #3

Closed natdan closed 7 years ago

natdan commented 7 years ago

@nebbian & @Benraay - do you want, maybe, me creating java project structure for you guys? Any ideas what should be project's groupId and artifactId? Package name? I know those are the least important things and the hardest for me to come up with something sensible! O: )

Benraay commented 7 years ago

Go for it ! So I can start the translation to Java !

Le mar. 30 mai 2017 à 11:16, natdan notifications@github.com a écrit :

@nebbian https://github.com/nebbian & @Benraay https://github.com/benraay - do you want, maybe, me creating java project structure for you guys? Any ideas what should be project's groupId and artifactId? Package name? I know those are the least important things and the hardest for me to come up with something sensible! O: )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nebbian/RoboxSlicerExtension/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs1WWzEZEKUzxA9kDyR5Fg_nGAZhUZsks5r-95hgaJpZM4NqBi3 .

--

Benjamin Raaymakers

CONFIDENTIALITY NOTICE:

The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in error, please immediately alert the sender by reply email and thendelete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, dissemination, copying, or storage of this message or its attachments is strictly prohibited.

nebbian commented 7 years ago

Doing the framework for this project and planning it out well, would be fantastic. I'd suggest the package name might be RoboxSlicerExtension, but I don't know much about the normal conventions on this sort of thing. The last time I touched Java was at university, so that's... ummm... 15 years ago...

You'd be a lot better placed to make those sorts of decisions.

I think we need to decide on the scope of what we want this project to do. My $0.02 is that it should do this:

I can't think of anything else, if this is the list then we need to think of a good name for something that does all those things. AutoMakerHelper? RoboxSlicerExtension?

natdan commented 7 years ago

:+1:

Project name goes without saying: 'Robox Slicer Extension' ('robox-slicer-extension' for maven artifactId, 'roboxslicerextension' for last part of the package, RoboxSlicerExtension for the class name, etc)

Group - that's where the problem is. Maven groupId, first part of the package (sometimes last part of the domain name) is where you describe 'organisation'/'group'/'group of projects', etc... The worse would be to say 'org.githib' as we have nothing to do with github except it being hosted here. Other options are 'com.roboxslicerextension', 'net.roboxslicerextension'... Any other 'virtual' company/organisation/something-else would be great! I have my own projects always done under org.ah (for short) or org.abstracthorizon as I have create web site (in days before github and such) and posted my projects there. I still do that (http://www.abstracthorizon.org and many other subdomains)

"Show a preview, if the existing slicer doesn't already have one. This might be an option for if people are happy to use the inbuilt Cura Robox slicer. (you've already done the work for this I think)" If we set up separate executable (of some kind) where you can select which flow do go with (which slicer to have) I would use the same app to select if such preview (see here: https://github.com/natdan/gcode-preview) can be switched on or off from the 'flow'. Also, same app should be able to set up any other local scripts user wants to add (some that just modify 'raw' gcode somehow/set pause gcode at particular level, etc).

👍 for all the other bullet points you put! Plus - try to keep it as platform agnostic as possible (read: it should work on Windows, as well! :))

nebbian commented 7 years ago

The group could be something like org.roboxenthusiasts? org.roboxslicerextension works as well. +1 for making it cross platform. For some reason us Mac people are in the majority for once, I don't want to treat Windows/Linux people with the same disdain that they've treated us with for years.

natdan commented 7 years ago

"For some reason us Mac people are in the majority for once, I don't want to treat Windows/Linux people with the same disdain that they've treated us with for years." LOL. I'm happy with org.roboxenthusiasts unless someone has better idea/strong(er) opinion(s)! :)

natdan commented 7 years ago

Oh, oh... There's another option (but not that good): com.roboxing! It is Tom Gidden's original web site (https://github.com/tomgidden) currently hosted at my servers... So it can accommodate (if really necessary) 'web side' of the project (no matter of name of the 'group').

nebbian commented 7 years ago

com.roboxing is probably the best one yet. Nice catch!

Benraay commented 7 years ago

go for the last option ! com.roboxing

Benjamin Raaymakers

CONFIDENTIALITY NOTICE:

The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in error, please immediately alert the sender by reply email and thendelete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, dissemination, copying, or storage of this message or its attachments is strictly prohibited.

2017-05-30 16:50 GMT+02:00 Ben Hitchcock notifications@github.com:

com.roboxing is probably the best one yet. Nice catch!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nebbian/RoboxSlicerExtension/issues/3#issuecomment-304903186, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs1Wc5wfw46qQFx7-t5iTbXhoJ_7VvQks5r_CzSgaJpZM4NqBi3 .

natdan commented 7 years ago

LOL - already in the pull request! :)

Benraay commented 7 years ago

sorry I have a lot of work this week my replies are a bit late you make good choices with @nebbian I let you decide for the first project structure !

Benjamin Raaymakers

CONFIDENTIALITY NOTICE:

The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in error, please immediately alert the sender by reply email and thendelete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, dissemination, copying, or storage of this message or its attachments is strictly prohibited.

2017-05-31 10:12 GMT+02:00 natdan notifications@github.com:

LOL - already in the pull request! :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nebbian/RoboxSlicerExtension/issues/3#issuecomment-305118130, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs1Wd6-SMQmGWHKj7u28bxnQHnsrg7Pks5r_SDogaJpZM4NqBi3 .

natdan commented 7 years ago

Oh, no - don't let you stop expressing what you had in mind. Nothing is set in stone!

nebbian commented 7 years ago

Thanks for the discussion guys. I think we've ended up with a beauty!