Allow libs to be built independently on Windows

nebgnahz / cv-rs

Rust wrapper for OpenCV (manual at this point)

https://nebgnahz.github.io/cv-rs/cv/

MIT License

204 stars 41 forks source link

Allow libs to be built independently on Windows #107

Closed vadixidav closed 5 years ago

vadixidav commented 5 years ago

I built the associated OpenCV on Linux and Windows (using my own CMake command, since the included powershell script was complaining about path lengths no matter what I did). On Windows, I didn't get an opencv_world lib. I assume this is due to not specifying INSTALL_CREATE_DISTRIB=ON.

I think that there should be an env var to support both build modes. I can add this functionality if desired. Is this acceptable? Also, I don't have a good name for the flag. What should it be?

Pzixel commented 5 years ago

Hello.

I see no harm in this behaviour, it would be even more consistent since linux actually doesn't build a world.

Flag may be called like "combine_world" or something. Have no good ideas now too :)

vadixidav commented 5 years ago

@Pzixel I actually came up with a better idea. I can just search if world is there and if it isn't I can try linking to the individual libs. Is this fine?

vadixidav commented 5 years ago

This should be solved by #117. When using the system installation on Linux it uses pkg-config and on Windows it just links every lib in the libs folder.