search

nebgnahz / cv-rs

Rust wrapper for OpenCV (manual at this point)
https://nebgnahz.github.io/cv-rs/cv/
MIT License
203 stars 41 forks source link

Memory leak fix #84

Closed Pzixel closed 5 years ago

Pzixel commented 6 years ago

Fixes #83

nebgnahz commented 6 years ago

Looks like rustfmt has some upgrades so the CI fails at format checking.

Pzixel commented 6 years ago

Looks like rustfmt has some upgrades so the CI fails at format checking.

That's fine, i will fix those.

Also, do you mind to fix double pr/push checks?

nebgnahz commented 6 years ago

Format fix as PR 1 and then rebase for PR 2 is probably better, just in case the memory fix introduces additional bug. But the because format is almost trivial, I am fine with you just combining both into 1 PR.

Pzixel commented 6 years ago

I do believe that invalid format occures in newly added code because I actually didn't have llvm on machine where I created the fix. So it's clearly should be one PR.