search

nebgnahz / cv-rs

Rust wrapper for OpenCV (manual at this point)
https://nebgnahz.github.io/cv-rs/cv/
MIT License
204 stars 41 forks source link

Adds canny edge detection #87

Closed joelgallant closed 5 years ago

joelgallant commented 6 years ago

Attached to Mat instead of making it a function with an src, dst signature, seemed like that is the preference in this lib.

Pzixel commented 6 years ago

The format checking is failing. You are probably uses invalid cargo fmt. You need have exactly same version, because they are a bit incompatible with each other. I will create a PR with fmt update because it's a shame.

Pzixel commented 6 years ago

Merge latest master. It should do the trick

Pzixel commented 6 years ago

CI currently uses rustfmt 0.8.2-nightly (5e59925 2018-07-02). You can check your version via cargo fmt --version. If your version differs then your code may not pass.

Don't forget to merge latest master to get correct .travis file. It was recently changed.

Sorry if it looks complicated, when you get familiar with it it won't take this much time.

joelgallant commented 6 years ago

Oops, should have checked first. Re-pushed with correct fix. (and is rebased on master)

Pzixel commented 6 years ago

Okay, now cargo fmt check passed, and it failed on clang one (we are using clang-format-5 if I remember correctly). And if you don't mind I'l post some some review comments.

P.S. Sorry for this much iterations, I think I just had to link out contributing readme which contains all required links.

joelgallant commented 5 years ago

Okay, I've updated this PR with a failing test and returning an EmptyResult @Pzixel

Pzixel commented 5 years ago

sorry, my new year finally ended :)

Thank you for your PR.