nebneuron / Simplicial.jl

A package for various computations with simplicial complexes, combinatorial codes, directed complexes and their filtrations.
Other
27 stars 9 forks source link

Simplicial is currently incompartible 2ith julia 0.7 #14

Closed vitskov closed 5 years ago

vitskov commented 6 years ago

Julia v"0.7 seems to have forbidden backslashes in docstrings. Compilation results in the following error below. The culprit is the usage of \{ in the docstrings... Apparantly it's a known issue with 0.7, and somehow they decided to go ahead with this change without deprecation period.. See eg. https://discourse.julialang.org/t/lots-of-things-are-now-breaking-in-0-7/4943

julia> VERSION v"0.7.0-beta.0"

julia> using Simplicial [ Info: Precompiling module Simplicial ┌ Warning: Deprecated syntax multiple line breaks between doc string and object at /home/vladimiritskov/.julia/dev/Simplicial/src/core.jl:35. │ Use at most one line break instead. └ @ nothing core.jl:35 ┌ Warning: Deprecated syntax multiple line breaks between doc string and object at /home/vladimiritskov/.julia/dev/Simplicial/src/core.jl:43. │ Use at most one line break instead. └ @ nothing core.jl:43 ERROR: LoadError: LoadError: syntax: invalid escape sequence Stacktrace: [1] include at ./boot.jl:317 [inlined] [2] include_relative(::Module, ::String) at ./loading.jl:1075 [3] include at ./sysimg.jl:29 [inlined] [4] include at /home/vladimiritskov/.julia/dev/Simplicial/src/Simplicial.jl:2 [inlined] [5] iterate at ./generator.jl:46 [inlined] [6] collect_to!(::Array{Any,1}, ::Base.Generator{Array{String,1},typeof(Simplicial.include)}, ::Int64, ::Int64) at ./array.jl:630 [7] collect_to!(::Array{typeof(max),1}, ::Base.Generator{Array{String,1},typeof(Simplicial.include)}, ::Int64, ::Int64) at ./array.jl:641 [8] collect_to_with_first!(::Array{typeof(max),1}, ::Function, ::Base.Generator{Array{String,1},typeof(Simplicial.include)}, ::Int64) at ./array.jl:617 [9] _collect(::Array{String,1}, ::Base.Generator{Array{String,1},typeof(Simplicial.include)}, ::Base.EltypeUnknown, ::Base.HasShape{1}) at ./array.jl:611 [10] collect_similar(::Array{String,1}, ::Base.Generator{Array{String,1},typeof(Simplicial.include)}) at ./array.jl:535 [11] map(::Function, ::Array{String,1}) at ./abstractarray.jl:1964 [12] top-level scope at none:0 [13] include at ./boot.jl:317 [inlined] [14] include_relative(::Module, ::String) at ./loading.jl:1075 [15] include(::Module, ::String) at ./sysimg.jl:29 [16] top-level scope at none:0 [17] eval at ./boot.jl:319 [inlined] [18] eval(::Expr) at ./client.jl:394 [19] top-level scope at ./none:3 [inlined] [20] top-level scope at ./:0 in expression starting at /home/vladimiritskov/.julia/dev/Simplicial/src/CombinatorialCodes/CodeOperations.jl:27 in expression starting at /home/vladimiritskov/.julia/dev/Simplicial/src/Simplicial.jl:14 ERROR: Failed to precompile Simplicial to /home/vladimiritskov/.julia/compiled/v0.7/Simplicial/iKPK.ji. Stacktrace: [1] error at ./error.jl:33 [inlined] [2] compilecache(::Base.PkgId) at ./loading.jl:1205 [3] _require(::Base.PkgId) at ./loading.jl:1007 [4] require(::Base.PkgId) at ./loading.jl:879 [5] require(::Module, ::Symbol) at ./loading.jl:874

sekunder commented 6 years ago

I would rather leave this issue open than the 1.0 issue, per the PSA here: https://discourse.julialang.org/t/psa-use-julia-0-7-if-you-are-upgrading/13321 In short, v0.7 exists to bridge the gap between 0.6 and 1.0, providing warnings where 1.0 will cause errors.

In the next few days I'll look at getting CombinatorialCode and SimplicialComplex working with v0.7 (and 1.0).

vitskov commented 5 years ago

most functions work fine in Julia 0.7