search

nebneuron / Simplicial.jl

A package for various computations with simplicial complexes, combinatorial codes, directed complexes and their filtrations.
Other
27 stars 9 forks source link

many simplicial complex operations are broken in Julia version 1.5 #25

Closed vitskov closed 4 years ago

vitskov commented 4 years ago

Some examples: C=CombinatorialCode([[1,2], [1,3], [2,3]]); k=SimplicialComplex(C); julia> link(k,[1,2]) ERROR: MethodError: no method matching iterate(::MaximalSetIterator{SimplicialComplex{Int64}}) Closest candidates are: iterate(::Combinatorics.IntegerPartitions) at /Users/vladimiritskov/.julia/packages/Combinatorics/Udg6X/src/partitions.jl:20 iterate(::Combinatorics.IntegerPartitions, ::Any) at /Users/vladimiritskov/.julia/packages/Combinatorics/Udg6X/src/partitions.jl:20 iterate(::Base.MethodList, ::Any...) at reflection.jl:871 ... Stacktrace: [1] iterate(::Base.Iterators.Filter{Simplicial.var"#79#81"{Set{Int64}},MaximalSetIterator{SimplicialComplex{Int64}}}) at ./iterators.jl:429 [2] iterate at ./generator.jl:44 [inlined] [3] grow_to!(::Array{Union{},1}, ::Base.Generator{Base.Iterators.Filter{Simplicial.var"#79#81"{Set{Int64}},MaximalSetIterator{SimplicialComplex{Int64}}},Simplicial.var"#78#80"{Set{Int64}}}) at ./array.jl:747 [4] collect(::Base.Generator{Base.Iterators.Filter{Simplicial.var"#79#81"{Set{Int64}},MaximalSetIterator{SimplicialComplex{Int64}}},Simplicial.var"#78#80"{Set{Int64}}}) at ./array.jl:684 [5] link(::SimplicialComplex{Int64}, ::Array{Int64,1}) at /Users/vladimiritskov/.julia/packages/Simplicial/G3A2o/src/SimplicialComplexes/SimplicialComplex.jl:214

vitskov commented 4 years ago

likevise, isvoid is broken:

isvoid(K) julia> isvoid(K) ERROR: MethodError: no method matching iterate(::MaximalSetIterator{SimplicialComplex{Int64}}) Closest candidates are: iterate(::Combinatorics.IntegerPartitions) at /Users/vladimiritskov/.julia/packages/Combinatorics/Udg6X/src/partitions.jl:20 iterate(::Combinatorics.IntegerPartitions, ::Any) at /Users/vladimiritskov/.julia/packages/Combinatorics/Udg6X/src/partitions.jl:20 iterate(::Base.MethodList, ::Any...) at reflection.jl:871 ... Stacktrace: [1] copyto!(::Array{Any,1}, ::MaximalSetIterator{SimplicialComplex{Int64}}) at ./abstractarray.jl:733 [2] _collect(::UnitRange{Int64}, ::MaximalSetIterator{SimplicialComplex{Int64}}, ::Base.HasEltype, ::Base.HasLength) at ./array.jl:630 [3] collect(::MaximalSetIterator{SimplicialComplex{Int64}}) at ./array.jl:624 [4] length(::SimplicialComplex{Int64}) at /Users/vladimiritskov/.julia/packages/Simplicial/G3A2o/src/SimplicialComplexes/SimplicialComplex.jl:82 [5] isvoid(::SimplicialComplex{Int64}) at /Users/vladimiritskov/.julia/packages/Simplicial/G3A2o/src/core.jl:99