nebneuron / Simplicial.jl

A package for various computations with simplicial complexes, combinatorial codes, directed complexes and their filtrations.
Other
27 stars 9 forks source link

Iterator fix #28

Closed sekunder closed 4 years ago

sekunder commented 4 years ago

Should fix #25, fix #26, fix #27

Also, fixed a strange bug where show(F) on a FiltrationOfSimplicialComplexes would print multiple times, and would print after every subsequent call to show

sekunder commented 4 years ago

Oh, should also fix #21

vitskov commented 4 years ago

Hi Alex,

Great! This fixed the Betti numbers computation, but it has also broken the transformation from Simplicial Complex to a directed complex (that used to work before :-((.

It seems that Klein Bottle is OK, but Poincarehomology three sphere is not. Bizarre! Please see issue 29 that I have opened.

this somehow worked:

julia> K=KleinBottle();

julia> D=DirectedComplex(K);

julia> BettiNumbers(K) Computing simplicial homology. This may take some time and memory.. Read 16 top simplices from Input File Writing Cell Complex From Non-manifold simplicial Complex Done! Complex stored with 48 cells! +++coreductions: 48 --> 4, fraction removed 0.916667 at height 1 +++reductions: 4 --> 4, fraction removed 0 at height 2 +++coreductions: 4 --> 4, fraction removed 0 at height 3 Computing Persistence Intervals! Linearly ordered 4 cells...

Done!!! Please consult [Temp*.txt] for results.

..done! 3-element Array{Int64,1}: 1 2 1

julia> BettiNumbers(D) Computing the poset structure....done! Now compute the Z_2-homology using the PHAT library....done. 3-element Array{Int64,1}: 1 2 1

julia> K=PoincareHomologyThreeSphere();

julia> D=DirectedComplex(K);

[HERE IT GETS STUCK ON AN INFINITE LOOP!!]

On Sep 19, 2020, at 6:24 PM, Alex Kunin notifications@github.com wrote:

Should fix #25, fix #26, fix #27

Also, fixed a strange bug where show(F) on a FiltrationOfSimplicialComplexes would print multiple times, and would print after every subsequent call to show

You can view, comment on, or merge this pull request online at:

https://github.com/nebneuron/Simplicial.jl/pull/28

Commit Summary

• basic iteration functionality works • show(CombinatorialCode) seems to work • fixed issue #26 • fixed bug where show(F) output multiple times File Changes

• M src/CombinatorialCodes/CombinatorialCodes.jl (50) • M src/Simplicial.jl (33) • M src/SimplicialComplexes/FiltrationOfSimplicialComplexes.jl (28) • M src/SimplicialComplexes/SimplicialComplex.jl (29) Patch Links:

https://github.com/nebneuron/Simplicial.jl/pull/28.patchhttps://github.com/nebneuron/Simplicial.jl/pull/28.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.