search

nebree8 / nebree8.com

nebree8.com
0 stars 1 forks source link

Placeholder about page with button in the drink list header #32

Closed audiodude closed 8 years ago

audiodude commented 8 years ago

screenshot 2016-06-20 21 04 15

screenshot 2016-06-20 21 10 46

audiodude commented 8 years ago

I messed up the order rating screen, need to fix.

audiodude commented 8 years ago

Okay I fixed it with a hack. I feel very ashamed of this hack so I guess....welcome to nebree8 development?

funrollloops commented 8 years ago

That is a hack, isn't it?

We could change it so that the order-status element actually takes up space on the screen instead of being absolutely positioned. The fixed positionining was just a quick hack to get it working.

This works fine for now though.

audiodude commented 8 years ago

I think the issue is that the <order-status> isn't part of ng-view and thus can't refer to the view's controller, otherwise we could just do AboutCtrl.showOrderStatus = false. Not the fixed positioning. Though I guess if it had static positioning, it would just fall off the bottom and not get displayed and there would be no need to hide it. I thought the fixed positioning had to do with the animation and keeping it at the bottom as users scroll.

funrollloops commented 8 years ago

Having a TopCtrl makes sense, though having the about screen hide the order status by wiring a bool through three controllers is definitely a little hacky.

On Mon, Jun 20, 2016 at 11:14 PM Travis Briggs notifications@github.com wrote:

I think the issue is that the isn't part of ng-view and thus can't refer to the view's controller, otherwise we could just do AboutCtrl.showOrderStatus = false.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/nebree8/nebree8.com/pull/32#issuecomment-227349855, or mute the thread https://github.com/notifications/unsubscribe/AAEnP2b2Uqyv-IPGFm6FnOhoVnwojoeaks5qN4E_gaJpZM4I6WES .