add new type: question - Githubissues

nebrelbug / react-admonitions

An admonitions React component, ported from remarkable-admonitions. Perfect for Docusaurus v2 and other React-based doc generators

https://nebrelbug.github.io/react-admonitions/

11 stars 4 forks source link

add new type: question #3

Closed arcturus140 closed 4 years ago

arcturus140 commented 4 years ago

This PR adds a new type of Admonition: Question. It closes #2.

Issues:

Black background on black text. With nested admonitions the text is unreadable after 10th level. I need to change colours

arcturus140 commented 4 years ago

final result:

nebrelbug commented 4 years ago

@arcturus140 this looks great! My one concern is that the colors don't seem to match perhaps quite as well with the others. Maybe you could use a color scheme generator tool?

nebrelbug commented 4 years ago

@arcturus140 here's a cool resource: https://coolors.co/3498db-2ecc71-e67e22-e74c3c-004777

nebrelbug commented 4 years ago

Perhaps a saffron, other yellow, or dark blue or green would work well.

arcturus140 commented 4 years ago

This should do it:

otherwise please pick colours yourself and I apply them.

nebrelbug commented 4 years ago

@arcturus140 this looks great! I'll try to merge and publish when I get home.

Thanks for your work!

arcturus140 commented 4 years ago

@nebrelbug how is the review going? Do you think it can be merged?

nebrelbug commented 4 years ago

@arcturus140 sorry this took so long! Just merged :)

nebrelbug commented 4 years ago

@arcturus140 react-admonitions 2.1.0 is now published :clap:! Thanks for being so patient while waiting for me to merge!

One last random question: where did you get the SVG for the emoji icon?

[Edit]: never mind, I found it in Octicons. It doesn't show up in the main page so I was really curious how you got it :smile: