search

nebuIr / Default-Dark-Mode

🌙 The Dark Mode Resource Pack for Minecraft: Java Edition
https://darkomizer.com
Other
147 stars 21 forks source link

✨Mod Support for Origins + AE2Things #44

Closed arichornlover closed 2 years ago

arichornlover commented 2 years ago

decided to put support for both of these! and if I gotten the names wrong then I am terribly sorry if they don't work

arichornlover commented 2 years ago

the weird thing is origins isn't working, I don't know the original file name of the mod. I'll look and look around for it.

arichornlover commented 2 years ago

sorry for the additional commits. I was fixing the origins issue and it's resolved now! 👍

arichornlover commented 2 years ago

1d64e82c79333ba18719776e796fb0be

arichornlover commented 2 years ago

Nebulr if your reading this then I am terribly sorry with the 7 commits, I screwed up 2 of the mods Origins & AE2Things and I had to fix them and make them work as intended. my fault for not removing extra directories in them.

nebuIr commented 2 years ago

First of all, thank you for your help! Always appreciated 👍 And no need to apologize for the additional commits, it happens 🙂

Regarding the Origins mod, I made a few color adjustments, added a missing texture, and marked only 1.19 as supported since this pull request only affects branch mc/1.19.

As for AE2 Things, I checked your changes and everything looks good 👍 Only thing I noticed is the file crystal_growth.png should be inside of an ae2 folder and not ae2things. But for the same reason as above, I removed the AE2 Things files from this pull request as it currently only supports 1.18. You can open a new pull request on the mc/1.18 branch and then I will go ahead and merge it.

arichornlover commented 2 years ago

Sorry my mistake! Next time I’ll merge it in those and make sure to check the Minecraft versions

arichornlover commented 6 months ago

Hey, seems like Origins isn’t Compatible for 1.20+ Versions I recently checked and saw that the textures were refactored in https://github.com/apace100/origins-fabric/commit/cc10de17cb40419027658a4c6dd4e3919983e7ec - branch/1.20 I’ll do improvements to it when I start updating mc textures

Sorry my mistake! Next time I’ll merge it in those and make sure to check the Minecraft versions

and I will still make sure to check the Minecraft versions. I will be prepared for it! 😁