search

nebula-contrib / nebula-jdbc

The JDBC connector for Nebula Graph.
41 stars 15 forks source link

update readme [master] #31

Closed Young-Flash closed 2 years ago

Young-Flash commented 2 years ago

@wey-gu now branch 3.0.0 is identical to master, if I make a PR to master, I should make another same PR to branch 3.0.0 to keep it identical to master. I think this isn't elegant enough, is there a better to achieve this goal?

wey-gu commented 2 years ago

Sorry I just saw this, yes, we have to cherry-pick the overall version mapping table, or other things are not only related to the single version in README for all tag/branches, how about this:

  1. in README, we only provide the information without version information and all version mapping table, like this: 
    <dependency>
<groupId>org.nebula-contrib</groupId>
<artifactId>nebula-jdbc</artifactId>
<version>$VERSION</version>
</dependency>
  2. Describe like you should replace $VERSION with 1.2.3 referring to the version mapping table.
  3. the version mapping table is placed under https://github.com/nebula-contrib/nebula-jdbc/wiki/Nebula-JDBC-Wiki#nebula-jdbc-version-mapping-to-nebula-graph-core

What do you think of this approach?

Young-Flash commented 2 years ago

ok

wey-gu commented 2 years ago

Thanks a lot @Young-Flash