search

nebula-contrib / nebula-jdbc

The JDBC connector for Nebula Graph.
41 stars 15 forks source link

move connectionpool to jdbc Connection from driver #39

Closed Nicole00 closed 2 years ago

Nicole00 commented 2 years ago

The Driver and Connection is circularly dependent, and driver should not maintain the Nebula connection pool.

If driver maintain the connection pool, when users use getConnection(url, user, password) to connect another nebula graph address, there would be connection mistakes, because the connection pool has been bind to the original address.

Nicole00 commented 2 years ago

this pr has been tested with Example, more unit tests will be added in the next or the next.next pr. @wey-gu @xiajingchun