add email validation - regex

nebula-plugins / gradle-contacts-plugin

Structure to define the owners of a project, then contributing this back to other plugins

Apache License 2.0

14 stars 8 forks source link

add email validation - regex #10

Closed rpalcolea closed 6 years ago

rpalcolea commented 6 years ago

Added email validation using regex.

While this could be accomplished with apache commons, two things:

means adding a dependency
it uses valid TLD domains that could potentially change and will make the plugin obsolete there

coveralls commented 6 years ago

Coverage increased (+3.9%) to 95.714% when pulling 6fdc4a9eda785ddd0312a4a4114c4504e9e90388 on rpalcolea:email-validation into 674dc1c3d007a3a0a44b1a84243a53d24feed1ae on nebula-plugins:master.

rpalcolea commented 6 years ago

Hi @sghill ,

Sorry for the delay.

Added the tests for happy path and also expanded a bit on scenarios for both valid and invalid emails.

sghill commented 6 years ago

Thanks @rpalcolea!