search

nebula-plugins / gradle-dependency-lock-plugin

A plugin to allow people using dynamic dependency versions to lock them to specific versions.
Apache License 2.0
293 stars 43 forks source link

Remove and flag features incompatible for configuration caching #235

Closed DanielThomas closed 2 years ago

DanielThomas commented 2 years ago

This appears to be the only place we're obviously incompatible with configuration caching (Gradle.buildFinished and TaskExecutionGraph.addTaskExecutionListener).

For the latter, the default since Gradle 7 has been a single lock file per-project, so dangling lock files are no longer a concern. Have I followed that logic correctly?

I'm also out of date on the dependency verifier, so I'll need some background on the problem it solves, but for now I'll just turn it off when configuration caching is enabled so I can get this working for Nebula internally.

OdysseusLives commented 2 years ago

It makes sense about getting rid of removeLockfilesForUnlockedConfigurations since the lockfile format is one file 👍