search

nebula-plugins / nebula-plugin-plugin

Plugin for plugins, heavily opinionated about nebula-plugins
Apache License 2.0
15 stars 15 forks source link

Integration test SourceSet should configure IDEA plugin if applied. #12

Closed bmuschko closed 10 years ago

bmuschko commented 10 years ago

If IDEA plugin is applied, configure the following for the integrationTest SourceSet:

rspieldenner commented 10 years ago

Looks good.

quidryan commented 10 years ago

Looks good. Can you also apply this logic to the facet plugin in the nebula-project-plugin?

bmuschko commented 10 years ago

@quidryan To avoid code duplication, should we potentially break this out into some sort of test suite plugin that also configures the IDEA plugin? Seems like multiple projects need this logic.

quidryan commented 10 years ago

I think we could replace the integration test logic here with the facet plugin, in which case there wouldn't be any duplication. I'd hold off on an ide plugin. It's a temping to add one though, we actually have a lot of IDE modification in the internal nebula code that could use a home.

bmuschko commented 10 years ago

That makes sense. I am going to pull the code into the facet plugin and try to apply the facet plugin to the plugin plugin.

quidryan commented 10 years ago

Great.

bmuschko commented 10 years ago

Closing this pull request. This is the new pull request against the project plugin.