search

nebula-plugins / nebula-plugin-plugin

Plugin for plugins, heavily opinionated about nebula-plugins
Apache License 2.0
15 stars 15 forks source link

Upgrade buildscans to latest plugin so it works with gradle 5 #48

Closed rpalcolea closed 6 years ago

rpalcolea commented 6 years ago

I noticed the following error when using build scans plugin 1.x

java.lang.NoClassDefFoundError: org/gradle/internal/operations/notify/BuildOperationNotificationListener2
        at com.gradle.scan.plugin.internal.i.i.a(SourceFile:19)
        at com.gradle.scan.plugin.internal.i.g.a(SourceFile:45)
        at com.gradle.scan.plugin.internal.i.g.a(SourceFile:25)
        at com.gradle.scan.plugin.BuildScanPlugin.a(SourceFile:448)
        at com.gradle.scan.plugin.BuildScanPlugin.a(SourceFile:416)
        at com.gradle.scan.plugin.BuildScanPlugin.apply(SourceFile:257)
        at com.gradle.scan.plugin.BuildScanPlugin.apply(SourceFile:130)
        at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:42)
        at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:50)

Looks like the change was introduced on this pull request -> https://github.com/gradle/gradle/pull/7023/files

So this would break with gradle 5

Removing build-scans plugin since we don't really use this