nebula-plugins / nebula-plugin-plugin

Plugin for plugins, heavily opinionated about nebula-plugins
Apache License 2.0
15 stars 15 forks source link

Remove build scans plugin #49

Closed rpalcolea closed 6 years ago

rpalcolea commented 6 years ago

I noticed the following error when using build scans plugin 1.x and gradle nightly.

java.lang.NoClassDefFoundError: org/gradle/internal/operations/notify/BuildOperationNotificationListener2 at com.gradle.scan.plugin.internal.i.i.a(SourceFile:19) at com.gradle.scan.plugin.internal.i.g.a(SourceFile:45) at com.gradle.scan.plugin.internal.i.g.a(SourceFile:25) at com.gradle.scan.plugin.BuildScanPlugin.a(SourceFile:448) at com.gradle.scan.plugin.BuildScanPlugin.a(SourceFile:416) at com.gradle.scan.plugin.BuildScanPlugin.apply(SourceFile:257) at com.gradle.scan.plugin.BuildScanPlugin.apply(SourceFile:130) at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:42) at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:50)

This change was introduced on this pull request -> https://github.com/gradle/gradle/pull/7023/files

Right now we can't introduce this RC as part of our workflow because it would break backwards compatibility:

Caused by: com.gradle.scan.plugin.UnsupportedGradleVersionException: Version 2.0-rc-1-20181004085302-release of the build scan plugin requires Gradle 5.0 or later.
You are currently using Gradle 4.10.2.

Nebula plugin-plugin provides the build-scan plugin to plugins that use it. With this breaking changes, I believe providing the build-scan plugin creates issues with backward compatibility

Thought?