search

nebula-plugins / nebula-release-plugin

Release opinions based around gradle-git
Apache License 2.0
220 stars 56 forks source link

Raising a GradleException if git command writes to stderr is wrong #246

Open oliverkuntze opened 10 months ago

oliverkuntze commented 10 months ago

In GitWriteCommandsUtil executeGitCommand you raise a GradleException if stderr is not empty. Since git writes its log to stderr this is misleading/false behaviour.

We tag our release versions using nebula release. Despite everything works fine our Gitlab Runner communicates the raised exception and it's stacktrace.

Could you please fix this behaviour?

Good that you swallow the exception and the CI job succeeds nonetheless. In our case. In general it would be helpful if an exception would fail the Gradle task. Renovate happily bumped nebula release's version and all pipelines were green until we wondered why our release pipeines were not triggered.

Cheers Oliver