nebulab / cangaroo

Connect Any App to Any Service
https://github.com/nebulab/cangaroo
MIT License
107 stars 18 forks source link

Persistence #19

Open iloveitaly opened 8 years ago

iloveitaly commented 8 years ago

Initial audit log / persistence implementation.

Dependent PRs:

TODO

mtylty commented 8 years ago

@iloveitaly could you please rebase this on the master branch?

iloveitaly commented 8 years ago

@mtylty slammed with other work at the moment, I'll get to this within 1-2 weeks.

bricesanchez commented 8 years ago

@iloveitaly Is the goal of this PR to provide a Translation table to keep source and destination ids of record ?

Like my warehouse product ID is 1 and the shopify ID is 60001 and this PR will add the feature to keep id 1 and 60001 ?

bricesanchez commented 8 years ago

It is probably more a feature to persist an unfinished job !? Like if one integration is down, it will retry to send the response until it works?

iloveitaly commented 8 years ago

It is probably more a feature to persist an unfinished job !? Like if one integration is down, it will retry to send the response until it works?

Not exactly. Here's some more information about the goals here

[0]

def perform?
  type == 'shipment' && self.payload_state == :new
end

cc @AlessioRocco

iloveitaly commented 8 years ago

@mtylty Rebased this PR on master, but it's dependent on the other smaller PRs I have open. Those will need to be merged before this passes.

Looking forward to hearing your thoughts!

iloveitaly commented 8 years ago

An example of what the Translation class allows for:

def perform?
  self.unique_state?
end

def unique_state?
  !self.
    translation.
    related_translations.
    map { |t| t.request['status'] }.
    uniq.
    include? self.payload['status']
end
iloveitaly commented 7 years ago

@AlessioRocco Any thoughts on this? I can rebase this PR if you have time to dig in.