51 cleaned up portions of the test suite to remove deprecation warnings generated by Rails5. Unfortunately, it made the test suite incompatible with Rails 4. That's because the post method used in the rspec tests is actually a part of Rails. And between Rails 4.2. and Rails 5.1. the arity of that method changed. The #post of 4.2. expected multiple positional arguments, i.e.
Using the new, non-positional arguments in the tests fixed the deprecation warnings for Rails 5 at the cost of breaking our Rails 4 tests. Since Rails 5 is still consistent with the old argument pattern (but Rails 4 is not consistent with the new pattern), I suggest that we revert for now. If/when they stop supporting the old arguments in Rails 5 we can decide whether its worth it to maintain backwards compatibility with Rails 4.
bricesanchez
commented
6 years ago
51 cleaned up portions of the test suite to remove deprecation warnings generated by Rails5. Unfortunately, it made the test suite incompatible with Rails 4. That's because the
postmethod used in the rspec tests is actually a part of Rails. And between Rails4.2.and Rails5.1.the arity of that method changed. The#postof 4.2. expected multiple positional arguments, i.e.whereas the
#postof5.1expects a hash, i.e.Using the new, non-positional arguments in the tests fixed the deprecation warnings for Rails 5 at the cost of breaking our Rails 4 tests. Since Rails 5 is still consistent with the old argument pattern (but Rails 4 is not consistent with the new pattern), I suggest that we revert for now. If/when they stop supporting the old arguments in Rails 5 we can decide whether its worth it to maintain backwards compatibility with Rails 4.