Open elia opened 1 year ago
Cool 😊 I am totally up for helping out, will check it out when I'm back at my computer.
I have been off for the summer, but I am now looking at how to handle whitespace differntly. Not satisfied with any solution yet :/
@elia Could you test out https://github.com/davidwessman/syntax_tree-erb/pull/51 and see if it makes sense to you?
This was my third take and the first time I managed to make all test pass. It feels like this will give more edge-cases, maybe I will have to reconsider it a few more times.
@elia
Now I feel more pleased with the changes syntax_tree-erb
does on your test cases.
Please give v0.10.5 a try 🙂 I do not have any good idea for handling e.g. frontmatter yet.
Nice 😊
I am thinking about how to handle style and javascript-blocks, so I might be able to solve frontmatter as well.
Is ERB allowed inside the frontmatter?
Consider joining forces with https://github.com/davidwessman/syntax_tree-erb as the project has done an awesome job already and with a few fixes we could get feature parity.
Currently trying to run it on existing fixtures has the following issues:
Found no matching erb-tag to the if-tag at line 6, char 208..351
#
char, might be intentional thoFoo
in<span>Foo</span>
can disrupt how the HTML is rendered%><%=
in<%= "Foo" %><%= "Bar" %>
can disrupt how the HTML is renderedcc @davidwessman the pretty print based approach of SyntaxTree is far superior to the long formatting script in this project, I thought was good to let you know I'm considering switching to it entirely in case you're interested in helping out 🙌