search

nebulab / erb-formatter

Format ERB files with speed and precision
MIT License
135 stars 22 forks source link

Fix for long attribute values containing = sign #44

Closed phil-janeapp closed 6 months ago

phil-janeapp commented 7 months ago
elia commented 7 months ago

Thanks @phil-janeapp, this looks great 🙌

I was wondering if there was a way to fix the UNQUOTED_VALUE regexp so that it covers both double " and single ' quoted values.

Also it should add test coverage for single quoted ones

phil-janeapp commented 6 months ago

@elia I added a test for single-quoted attributes. Can you clarify what you meant about the UNQUOTED_VALUE check? In looking at the code there shouldn't be an issue with different quote styles.

elia commented 6 months ago

Hey @phil-janeapp, sorry for letting you wait, I ended up checking out the branch to try the code out and implemented what I meant, feel free to check it out.

Thanks for tackling this! 🙌