search

nebulapackage / nebula

Nebula is a minimalistic and easy to use administration tool for Laravel applications, made with Laravel, Alpine.js, and Tailwind CSS.
https://nebulapackage.com
225 stars 27 forks source link

Clean up the service provider #32

Closed Larsklopstra closed 4 years ago

Larsklopstra commented 4 years ago

The service provider contains too much logic, consider separating the route binding

johnnyfekete commented 4 years ago

Hi @Larsklopstra I'd gladly do this PR

Do you have any preference, where to put the bindings? Maybe a new file, something like src/Http/RoutesResolver.php?

Then it could have the 3 methods for the route bindings, and maybe the mapWebRoutes as well.

Or if you were thinking something totally different, tell me, I'd be glad to do it 🙂

Larsklopstra commented 4 years ago

@johnnyfekete that sounds like a plan :) Perhaps even 

LarsKlopstra\Nebula\Http\RouteResolvers

- ResourceResolver.php
- ItemResolver.php