search

nebulasio / go-nebulas

Official Go implementation of the Nebulas protocol.
https://nebulas.io
GNU Lesser General Public License v3.0
712 stars 203 forks source link

Nebulas segwit support discuss #38

Closed qywang2012 closed 6 years ago

qywang2012 commented 6 years ago

Nebulae are discussing whether to use Segregated Witness. Should we need to separate the signatures from transaction body?

segwit

Anyone can comment on this and discuss it.

smartpunter commented 6 years ago

As long, as there is no mainnet and you are free to broke everything, and you feel like you are capable of implementing it, there is no reason not to do this, working with segwit protocol is a bit easier for developers, because txid is guaranteed to be intact.

Some interesting reading here: https://bitcoincore.org/en/2016/01/26/segwit-benefits/

fbzhong commented 6 years ago

After reading some articles, the segwit is used to solve the txid issue in bitcoin, which is not exist in nebulas protocol.

It seems like the only benefit of segwit liked design is "less transaction data size (-65bytes)" in Chunk Sync mode.

Let me know when I miss anything.

smartpunter commented 6 years ago

Well, i also thought at the beginning, that segwit is not necessary for pos consensus blockchains...

Do you think it would be possible to make such changed in block structure later, using Protocol Code? If yes, than it is easy decision not to bother with SegWit now. If no, than we need some other opinions :)

fbzhong commented 6 years ago

Seems like the issue related to Segwit does not exist in Nebulas.

Close this issue.