nebulasio / go-nebulas

Official Go implementation of the Nebulas protocol.
https://nebulas.io
GNU Lesser General Public License v3.0
712 stars 203 forks source link

Github client id and secret leftovers #92

Closed eur0pa closed 6 years ago

eur0pa commented 6 years ago

I was going to report this "elsewhere", but I'm not sure it pertains your scope. This set of credentials give access to GitHub as an organization and exposes data for all its members–you might want to assess whether it's a liability or not.

https://github.com/nebulasio/go-nebulas/blob/415c6ab50279aefb2ff37f447bf28a01b1e94f46/net/testing/test/main.go#L12

ChengOrangeJu commented 6 years ago

Hello @eur0pa , thanks for your information, that's very helpful. Generally, this is an github account that is created by internal team members temporarily to test dependencies and make no harm. However, I agree with you that it is better not to reveal it in the repo. Thanks!

ChengOrangeJu commented 6 years ago

Hello @eur0pa , Code removed in develop branch, thanks again.