nebulasio / neb.js

GNU Lesser General Public License v3.0
83 stars 46 forks source link

"claim tokens" in example.html 404 #58

Closed 1c7 closed 6 years ago

1c7 commented 6 years ago

2018-August-20

1. Expect

claim Testnet token successfully when click "claim token"
image

Note: I did some change to source code, so in above screenshot, part of text is in Chinese. the original example.html is all English

2. What actually happen

I get 404 error

image image

Please fix it

image

1c7 commented 6 years ago

Chrome developer tool, network tab

image

1c7 commented 6 years ago

Question

I know developer can claim token here:
https://testnet.nebulas.io/claim/ image

so are you guys gonna fix this claim token API in example.html, or just replace this Step 2 with this address: https://testnet.nebulas.io/claim/ ?

yupnano commented 6 years ago

The claim token API in example.html is no longer supported. You should claim token manually here.

This is because there is always someone trying to claim testnet tokens with scripts.

1c7 commented 6 years ago

@yupnano Understood.

So example.html Step 2 should display this link: https://testnet.nebulas.io/claim/
not a button anymore.

Should I send a PR? or you change it? it just couple line of code

yupnano commented 6 years ago

please send a PR, 👍

1c7 commented 6 years ago

@yupnano no problem :) I would send PR in about 5 minute

1c7 commented 6 years ago

@yupnano done. https://github.com/nebulasio/neb.js/pull/60

yupnano commented 6 years ago

Many thanks~