search

nebulous / infinitude

Open control of Carrier/Bryant thermostats
MIT License
225 stars 50 forks source link

Upgrade dependencies #133

Closed mamarley closed 2 years ago

mamarley commented 2 years ago

-Upgrade angular.js and related libraries to 1.8.2 -Switch to new API for $http response -Stop using the "!" hash prefix -Fix controllers getting loaded multiple times by loading MainCtrl once for the entire body and not loading controllers in app.js -Drop json3 (no remotely-modern browsers need this anymore) -Drop es5-shim (no remotely-modern browsers need this anymore) -Upgrade jquery to 3.6.0 -Upgrade bootstrap to 3.4.1 -Add override for bootstrap.css since it was removed from bootstrap's bower.json -Upgrade bundled glyphicons-halflings to match bootstrap version -Upgrade c3 to 0.7.20 -Upgrade angular-timeago to 0.4.6 -Drop ng-knob (unused) -Upgrade angular-chart.js to 1.1.1

ngTimepicker claims to be incompatible with angular.js above 1.4.x, but my testing reveals that it works fine, at least in this application.

This also cherry-picks https://github.com/cdjackson/angular-dialgauge/pull/12 (which fixes https://github.com/nebulous/infinitude/issues/24) and https://github.com/cdjackson/angular-dialgauge/pull/11 (which fixes an issue introduced by https://github.com/nebulous/infinitude/commit/6dd47b6adca250c33606cc81d2d17b7a7d38f332 where the scaleMax value for the CFM dial would sometimes not be set correctly on page load, resulting in no bar being displayed.

mamarley commented 2 years ago

Are there any issues with this? I've got some other stuff coming too, like making the Profiles and Schedules pages pause updating when the user is editing (to avoid the updates clobbering the changes), but I can't really submit that until this is resolved.

nebulous commented 2 years ago

Are there any issues with this? I've got some other stuff coming too, like making the Profiles and Schedules pages pause updating when the user is editing (to avoid the updates clobbering the changes), but I can't really submit that until this is resolved.

It looks fine in static analysis. I haven't had a chance to actually build it yet. Since it only touches the web interface though we can probably be cowboys now and rollback if there's trouble. 🤠

mamarley commented 2 years ago

Thanks! I thoroughly tested everything except serial (because the only system I have to test doesn't have a serial adapter attached). If any related bug reports come in, please shoot them my way.