nebulous / infinitude

Open control of Carrier/Bryant thermostats
MIT License
224 stars 50 forks source link

Expose the profile data from the state cache #174

Closed jaevans closed 1 year ago

jaevans commented 1 year ago

Exposing this allows retrieving information such as the unit serial and model numbers via the API.

Closes #173

nebulous commented 1 year ago

Thanks for the contribution, @jaevans! I'm wondering if this is meaningfully different from the existing /profile.json endpoint though? Any keys in the Infinitude store(requests/responses/text/xml/jaon) can be retrieved at the root path, which is how the Infinitude web interface works. See /api/state_keys for available keys.

jaevans commented 1 year ago

Nope, /profile.json has what I need. I just misunderstood the api a bit. I'll close the PR and issue.

nebulous commented 1 year ago

glad to hear it. If you have any suggestions/wiki edits/README PRs for the documentation which would have made the above more clear - you're probably not the only person to have gone down this route so you have the best context to make it more clear for the next traveler. All contributions welcome!