nebulous
commented
2 months ago How about using a mutli-stage build? I'm open to being convinced otherwise, and happy to help lower friction, but this just feels like the wrong place to solve this problem.
github-actions[bot]
The context is that I've put together a HA addon: https://github.com/sosheskaz/infinitude-ha-addon.
I am interested in changing the base to use hassio, as you suggest. I don't think that necessarily makes sense in other contexts though.
From a separation of concerns perspective, I would rather not use my own Dockerfile, as I'm not very knowledgeable about PHP, just integrating Infinitude as it exists with hassio — this allows me to isolate just the "glue", without needing to worry about code changes or dependencies, instead just being able to consume infinitude's source.
Another aspect is that I want immutable images for the sake of reliable upgrades and rollback — upgrading to a different image tag with each update has the nice characteristic in hassio of allowing me to make it appear in the UI as an upgrade, and to allow rollback by just reverting to an old image, and... in general, making any given commit in my addon a viable snapshot of state. In that vein, I would benefit from immutable versioning of infinitude itself.
The hassio layer also has some extra needs, mostly to translate from hassio vars into infinitude's config: https://github.com/sosheskaz/infinitude-ha-addon/blob/main/docker/run.sh. This isn't that big, but again, with separation of concerns, I'm not sure that makes sense to contribute upstream. I'd be open to that... I just recall reading in a previous convo somewhere that you did not have a viable setup for testing releases of a HA addon, whereas I'm able to run my own experimental branch for any changes that come up.
I'm open to any other way you'd like to split that up though; my submodule solution is hardly graceful.
Sidenote, I really appreciate the work you've done on this project! Very nice to actually be able to use my thermostat how I like.