search

necaris / conda.el

Emacs helper library (and minor mode) to work with conda environments
MIT License
153 stars 49 forks source link

Fix/deprecated conda activate command #108

Closed jinschoi closed 2 years ago

jinschoi commented 2 years ago

Conda.el stopped working for me after upgrading to 4.13.0 due to deprecated "conda ..activate" being removed. I saw that there was this branch to address it, but there were a few issues that kept it from working, which I address in this pull request. See issue https://github.com/necaris/conda.el/issues/107

  1. The conda version test called to see if the json activator is supported is backwards.
  2. "conda shell.posix+json deactivate" does not allow any more arguments now.
  3. setenv was getting called directly from the results of parsed JSON, which could be symbols (like 'CONDA_PREFIX) or integers (like 1). Have to force both arguments to strings.