necaris / conda.el

Emacs helper library (and minor mode) to work with conda environments
MIT License
153 stars 49 forks source link

environment activation fails if `conda` is not in `exec-path` #113

Closed keewis closed 2 years ago

keewis commented 2 years ago

23 added compatibility with new conda versions, but it uses the string "conda" as a command in several places (not sure if I found all of them):

https://github.com/necaris/conda.el/blob/ed92b4bab3b2a7868aa1b70d852cf5bdd082ea6c/conda.el#L129 https://github.com/necaris/conda.el/blob/ed92b4bab3b2a7868aa1b70d852cf5bdd082ea6c/conda.el#L248-L249 https://github.com/necaris/conda.el/blob/ed92b4bab3b2a7868aa1b70d852cf5bdd082ea6c/conda.el#L271-L272 This will fail if conda is in (f-join conda-anaconda-home conda-env-executables-dir) but not in exec-path.

You might be able to fix that by adding a function that constructs conda-executable-path from conda-anaconda-home and conda-env-executables-dir, and calling that whenever the conda executable is needed.