Refactor current-name -> current-path

necaris / conda.el

Emacs helper library (and minor mode) to work with conda environments

MIT License

153 stars 49 forks source link

Refactor current-name -> current-path #66

Closed arthurcgusmao closed 4 years ago

arthurcgusmao commented 4 years ago

The conda-env-current-name was being used for storing both path and name of environments, depending on whether it was being called by conda-env-activate or conda-env-activate-path.

This commit removes this ambiguity, and also removes duplicate code that become unnecessary after the simplication.

Moreover, this commit fixes an existing bug (described in #47) where the package was unable to deactivate a base environment set with the hack (conda-env-activate "..").

necaris commented 4 years ago

@arthurcgusmao this looks great! Thank you for this PR -- I love seeing net deleted lines of code!

arthurcgusmao commented 4 years ago

Awesome, I'm glad you approved it :)