search

necauqua / chiseled-me

A mod that can make you small to sneak into places
MIT License
15 stars 11 forks source link

Customnpc hitbox weirdness #65

Closed Catlord-3 closed 3 years ago

Catlord-3 commented 3 years ago

Custom npcs npcs do not properly scale using recalibrators

To Reproduce Steps to reproduce the behavior:

  1. Create an npc using custom npcs
  2. Use a volume recalibrator on them (due to their interact feature you need to be like 5 blocks away to do this)
  3. Us f3+b to see broken hitbox (upon resizing back to normal hitbox is still broken, its larger but not correct)

I tested and this is not a visual issue, this is their actual hitbox.

Expected behavior Customnpcs would scale like all other mobs

Screenshots 2020-09-16_13 39 03 2020-09-16_13 38 48

Additional information:

Catlord-3 commented 3 years ago

A note: they both have the same nbt data exactly, except for the size change. they are clones of each other.

necauqua commented 3 years ago

same nbt data exactly

So a relog should fix it I guess.

Well customnpc has some weird setSize interactions I even do recall knowing about something like that somehow. Will check and possibly fix

necauqua commented 3 years ago

Was a crude fix for their weird custom hitbox stuff, but then I went full ~re..~ ocd and also fixed shadows, name height and gui rendering.

Note that big CustomNPC entites will often not be rendered - but this is a weird CustomNPC bug (happens to size 1 entities too) that I have no idea how to fix nor I really want to.