search

necauqua / obsidian-page-properties

A plugin that adds Logseq-like page tags to Obsidian
MIT License
21 stars 2 forks source link

[Bug] Autolink patterns don't work when Translate plugin is enabled #4

Closed meskill closed 1 year ago

meskill commented 1 year ago

If the Translate plugin is enabled then links from pattern (github, wiki etc) point to wrong urls like https://github.com/%7B0%7D

necauqua commented 1 year ago

Issue comes from the translator plugin, they are doing something pretty dumb which breaks everyones code, the fix has to come from them

necauqua commented 1 year ago

The %7B0%7D part is just url-encoded {0} from the link patterns, the translator plugin changes how the String.format call works for the entire application so that instead of replacing {0}, {1} etc it only replaces consecutive {}s

The funniest part is that the comment says 'make it like in python', while the full Python formatter does support {0}, {1} etc as well as {} (for the obvious reason of if you want to reorder things).

Anyway, until they fix that you can change the autolink patterns to have {} instead of {0} :shrug:

Fevol commented 1 year ago

I'd really like to apologize for this absolutely brain-dead mistake I made. This was code I've left in and never ended up using. I either never ended looking at the function again, or didn't realize why keeping it in is a bad idea. I'll be taking a look at my entire code again, and try to prevent something like this ever happening again.

Thank you @meskill for detecting the problem, and pointing it out by creating this issue. I am immensely grateful. Sorry @necauqua for any worries I might've caused.

meskill commented 1 year ago

I'm glad that is resolved. Thank you guys for your work!