necodeIT / lb_planner_plugin

Moodle Plugin for the LB Planner app
Other
1 stars 0 forks source link

implementing remaining slot booking TODOs #22

Closed RiedleroD closed 1 week ago

RiedleroD commented 1 month ago

all the important stuff to finish the slot booking service

RiedleroD commented 2 weeks ago

The slots subpackage should now be complete in terms of services to implement. I think we should merge this before fixing the remaining three issues, because:

RiedleroD commented 2 weeks ago

@mcquenji please check if there's any problems wrt API structure. Obviously you don't need to look at the exact implementations. You can read the docs by copying the array from the CI results and putting it into the scrips.js of your local copy of the docs website thingy.

mcquenji commented 1 week ago

image

id dont quite understand what this is used for, as they arent used as a parameter in any other endpoint (maybe im missing something?)

rest looks good

mcquenji commented 1 week ago

oh my bad, are they used to limit who can book a slot? if so, maybe rename them to access_rule or something?

RiedleroD commented 1 week ago

yes, I was thinking of renaming them. We can discuss names for this tomorrow

RiedleroD commented 1 week ago

slot filter renamed: whitelist (or whitelist_rule for the individual elements making up the whitelist)

RiedleroD commented 1 week ago

gonna actually rename everything in a separate PR so I can get this merged sooner rather than later