necolas / normalize.css

A modern alternative to CSS resets
http://necolas.github.io/normalize.css/
MIT License
52.32k stars 10.66k forks source link

Remove the gap #843

Open Ksengine opened 3 years ago

Ksengine commented 3 years ago

Remove the gap between audio, canvas, iframes,images, videos and the bottom of their containers

i suggest:

audio,
canvas,
iframe,
img,
svg,
video {
  vertical-align: middle;
}

you added this as:

/**
 * 1. Correct `inline-block` display not defined in IE 8/9.
 * 2. Normalize vertical alignment of `progress` in Chrome, Firefox, and Opera.
 */

audio,
canvas,
progress,
video {
  display: inline-block; /* 1 */
  vertical-align: baseline; /* 2 */
}

can you explain me

Stefan-Orn commented 3 years ago

thank you

mið., 28. okt. 2020 kl. 15:50 skrifaði Kavindu Santhusa < notifications@github.com>:

Remove the gap between audio, canvas, iframes,images, videos and the bottom of their containers

  • audio,
  • canvas,
  • iframe,
  • img,
  • svg,
  • video

i suggest:

audio, canvas, iframe, img, svg, video { vertical-align: middle; }

you added this as:

/**

    1. Correct inline-block display not defined in IE 8/9.
    1. Normalize vertical alignment of progress in Chrome, Firefox, and Opera. */

audio, canvas, progress, video { display: inline-block; / 1 / vertical-align: baseline; / 2 / }

can you explain me

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/necolas/normalize.css/issues/843, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6WJFF5FXNZ6H3DS6YS2OTSNA4VJANCNFSM4TCQJJQQ .

garrettw commented 3 years ago

Remove the gap between audio, canvas, iframes,images, videos and the bottom of their containers

Is this something that most browsers are already doing, and only a few are not?

(This project is only for normalizing the differences between browsers, not making opinionated changes that affect all browsers.)

Ksengine commented 3 years ago

normalize should support many browsers

Ksengine commented 3 years ago

we should use vertical-align: baseline to all audio, canvas, iframe, img, svg, video

miquelfire commented 3 years ago

What browsers are using baseline?

Ksengine commented 3 years ago

its the default

The vertical-align property sets the vertical alignment of an element. Default value: baseline

w3schools

garrettw commented 3 years ago

Rule # 1 of web design: NEVER rely on, or quote, W3Schools as a reliable resource.

normalize should support many browsers

It does that. I never suggested otherwise.

we should use vertical-align: baseline to all audio, canvas, iframe, img, svg, video

What?? In your first post you suggested middle for them all! If you're going to make a suggestion, at least make up your mind and be consistent.

Ksengine commented 3 years ago

Rule # 1 of web design: NEVER rely on, or quote, W3Schools as a reliable resource.

why?

Ksengine commented 3 years ago

i learned vertical-align: middle from html5 boilerplate vertical-align: baseline is from W3Schools

garrettw commented 3 years ago

https://www.quora.com/What-is-wrong-with-W3Schools-that-it-is-often-referred-to-as-a-bad-resource-for-learning

https://meta.stackoverflow.com/questions/280478/why-not-w3schools-com

It's not as bad as it used to be, but MDN has always been a better and more reliable resource.

Ksengine commented 3 years ago

thank you very much